Skip to content

Install .NET 6 SDK to re-enable XAML Styler #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2025
Merged

Install .NET 6 SDK to re-enable XAML Styler #294

merged 2 commits into from
Sep 25, 2025

Conversation

Arlodotexe
Copy link
Member

Fixes

This PR fixes the error observed at this CI run by installing the .NET 6 SDK explicitly.

Log for failed CI step:

Run powershell -version 5.1 -command "./ApplyXamlStyling.ps1 -Passive" -ErrorAction Stop
Use 'Help .\ApplyXamlStyling.ps1' for more info or '-Main' to run against all files.

Restoring dotnet tools...
Tool 'uno.check' (version '1.27.4') was restored. Available commands: uno-check
Tool 'xamlstyler.console' (version '3.2206.4') was restored. Available commands: xstyler
Tool 'microsoft.visualstudio.slngen.tool' (version '12.0.13') was restored. Available commands: slngen

Restore was successful.
Checking all files (passively)
You must install or update .NET to run this application.

App: C:\Users\runneradmin\.nuget\packages\xamlstyler.console\3.2206.4\tools\net6.0\any\xstyler.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '6.0.0' (x64)
.NET location: C:\Program Files\dotnet\

The following frameworks were found:
  8.0.6 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  8.0.19 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  8.0.20 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  9.0.6 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  9.0.8 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  9.0.9 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

Learn more:
https://aka.ms/dotnet/app-launch-failed

To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=6.0.0&arch=x64&rid=win-x64&os=win10
Error: Process completed with exit code 1.

Other information

See also actions/runner-images#12241

@niels9001 niels9001 self-requested a review September 19, 2025 15:02
@Arlodotexe Arlodotexe mentioned this pull request Sep 25, 2025
Merged
michael-hawker
michael-hawker requested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just update the XAML Styler version in #295 and close this one.

.github/workflows/build.yml

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# .NET 6 SDK is required for xamlstyler.console to run.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a newer version of XAML Styler which supports newer .NET versions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the latest available on nuget

@Arlodotexe Arlodotexe changed the base branch from main to feature/migrate-to-large-runners September 25, 2025 21:39
@Arlodotexe Arlodotexe merged commit c313acd into feature/migrate-to-large-runners Sep 25, 2025
5 of 11 checks passed
@Arlodotexe Arlodotexe deleted the fix/ci/xamlstyler/net6-required branch September 25, 2025 21:39
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Sep 25, 2025 •
edited
Loading

Strange, I changed the base branch and it auto-closed? 🤔 I had another commit to push, needs to be reopened.

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Sep 25, 2025 •
edited
Loading

GitHub isn't giving me a way to reopen the branch, and it looks like these changes are now present in the base branch that was merged.

We'll just continue the PR in #295 then, but these changes should have been made before this PR was closed and merged into the base, not after.

@michael-hawker
Copy link
Member

But we don't want to install .NET 6 anymore, eh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-hawker michael-hawker michael-hawker requested changes

@niels9001 niels9001 niels9001 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Arlodotexe @michael-hawker @niels9001